Replace ADO tests with GitHub actions #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
changed the title
davidmrdavid
commented
Jun 19, 2024
| @@ -10,7 +10,6 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="1.0.30" /> | |||
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="2.3.0" /> | |||
| <PackageReference Include="Newtonsoft.Json" Version="9.0.1" /> | |||
There was a problem hiding this comment.
inherited from WebJobs project
davidmrdavid
commented
Jun 19, 2024
Comment on lines
+257
to
+258
| internal IHost InnerHost { get; private set; } | ||
|
|
There was a problem hiding this comment.
this resolves a build warning
davidmrdavid
commented
Jun 19, 2024
| timeout = Debugger.IsAttached ? TimeSpan.FromMinutes(5) : TimeSpan.FromSeconds(30); | ||
| timeout = Debugger.IsAttached ? TimeSpan.FromMinutes(5) : TimeSpan.FromMinutes(1); |
There was a problem hiding this comment.
GitHub actions + Azurite seems to run tests more slowly, so I added more buffer time
davidmrdavid
commented
Jun 19, 2024
Comment on lines
+749
to
+751
| // add a minute wait to ensure logs are fully written | ||
| await Task.Delay(TimeSpan.FromMinutes(1)); | ||
|
|
There was a problem hiding this comment.
more buffer time to account for GH action slowness
davidmrdavid
commented
Jun 19, 2024
| { | ||
| if (parent.Id == some.Context.Operation.ParentId) | ||
| { | ||
| Console.WriteLine("match"); |
There was a problem hiding this comment.
writing to console in GitHub actions is flakey and can cause runtime errors. So I removed this, which was only there for debugging purposes
nytian
approved these changes
Jun 19, 2024
bachuv
reviewed
Jun 19, 2024
bachuv
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our 1ES migration - we're replacing our ADO unit, integration, and end to tests with GitHub actions that use Azurite as a backing Azure Storage store. This PR does just that: it creates 3 new GitHub actions - one for the analyzer tests, one for the E2E tests, and another for the remaining tests.
Finally, this PR also resolve a myriad of build warnings, for clean up sake.